Fix errors in dashboard build #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
ci-build |
`ICheMachineSourceTypes` was defined as an interface using the enum syntax. Fix this. Signed-off-by: Gerben Oolbekkink <g.j.w.oolbekkink@gmail.com>
|
Updated to fix merge conflicts |
|
ci-build |
ashumilova
approved these changes
Mar 14, 2019
olexii4
approved these changes
Mar 20, 2019
...app/workspaces/workspace-details/workspace-overview/workspace-details-overview.controller.ts
Outdated
Show resolved
Hide resolved
|
FYI: After reviewing your changes, I have created one more PR for live discussion all that was additionally done during checking. As for me, build output became much better after. |
|
@ashumilova @olexii4 I changed the attributes in |
|
ci-build |
ashumilova
reviewed
Mar 22, 2019
dashboard/src/components/api/workspace/che-workspace.factory.ts
Outdated
Show resolved
Hide resolved
Define the attributes property on `IWorkspaceConfig` as an interface. Signed-off-by: Gerben Oolbekkink <g.j.w.oolbekkink@gmail.com>
|
ci-build |
|
@qurben Thank you a lot for your contribution and patience for feedbacks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix errors reported by the dashboard build.
ICheMachineSourceTypeswas defined as an interface using the enumsyntax. The attributes property on
IWorkspaceConfigis defined as a map butnot used as such on some locations.
What issues does this PR fix or reference?
#12825
Release Notes
N/A
Docs PR
N/A