dashboard: scripts refactored, unit tests enabled

[ppitonak]

What does this PR do?

Running mvn clean install did not run unit test. This PR

1. changes npm scripts so that npm install only installs dependencies and doesn't run build
2. updates pom.xml so that it uses yarn binary correctly
3. updates the Dockerfile to call npm install just once, not to use npx unnecessarily and run unit tests

KNOWN ISSUE:

• yarn is installed in Dockerfile but the base image already contains yarn, the installed version is not used
• possible solutions: don't run npm i yarn in Dockerfile and (optionally) remove it from package.json OR call yarn binary explicitly using whole path (node_modules/.bin/yarn) as it's done in pom.xml

What issues does this PR fix or reference?

Release Notes

N/A

Docs PR

[che-bot]

Can one of the admins verify this patch?

[che-bot]

Can one of the admins verify this patch?

[che-bot]

Can one of the admins verify this patch?

[qurben]

On the known issue: running npm i yarn creates a package-lock.json file, because there is none yet, this can cause warnings. So this command actually should be removed.

I'd use npx yarn for the native build, so that it can work with just installing node and it seems as fast as just calling yarn

[olexii4]

@ppitonak Good improvement. Thank you.
I am checking. I see several more copy/paste typos. One of them broke namespace 'che' and we have errors after.
https://github.com/eclipse/che/blob/master/dashboard/src/components/typings/che.d.ts#L176
I changed to

    export interface ICheMachineSourceTypes {
      TOOL: string;
      RECIPE: string;
    }

And something else. I will check.

[ppitonak]

@qurben do you want me to remove that npm i yarn?
@olexii4 yes, there are a lot of warnings but I didn't want them to mix into this PR

[qurben]

@olexii4 In #12826 the errors with che namespace and other ts errors are fixed.

@ppitonak I think that would really make sense (I don't have any authority in this repo though)

[olexii4]

@ppitonak I found the problem: you didn't fix the native build 'mvn clean install -Pnative'.

<!-- build user dashboard -->
 <exec dir="${basedir}" executable="node_modules/.bin/yarn" failonerror="true">
       <arg value="build" />
</exec>

It should be added in this line:
https://github.com/eclipse/che/blob/c88e07d78354f29926c5462be51face8cbd83978/dashboard/pom.xml#L225
Or return this back

 "postinstall": "yarn run typings && yarn run build" 

WDYT?

[ppitonak]

@olexii4 you are right that it's broken now but your solution is not 100% correct. I pushed new version.

[olexii4]

It is not

install yarn 

now

[ppitonak]

I'll fix it

[olexii4]

So many people, so many minds. Everyone has his own ideas ))

[ppitonak]

@olexii4 I have two guiding principles in this PR

1. it should be logical so that new team member will understand what it does, e.g. install deps step only installs dependencies, doesn't build the project etc.
2. the same commands are called whenever you use maven (docker or native), docker manually or yarn directly - this proved to be a correct approach in my past projects

[olexii4]

Logically. You are quite right. It happens depends on the long story of this project. A long time ago it was a separate repo...
I agreed with it for the first time. Told you thanks and a note 'good improvement'. And immediately approved it.

I just note you previously what you lost in the simplest way. And you know - I tried to avoid it.

Thank you a lot. Good job.

[ppitonak]

When will the Jenkins job start?

[olexii4]

If I am not mistaken: 22.00 or 23.00

[ppitonak]

@olexii4 I mean the PR check... now I noticed message from @che-bot that an admin needs to approve it

[olexii4]

It depends. We do not have a special time. If there will be a free slave...

It can be approved after ci-test

[olexii4]

ci-test

[ppitonak]

@olexii4 no I cannot run these commands because I'm not part of team and I haven't been white-listed ;)

[ashumilova]

ci-build

[che-bot]

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12923
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

[ppitonak]

@ashumilova what will happen now? Will somebody review the results of e2e tests?

[ashumilova]

@ppitonak merged, thank you for cleanups and enabling tests.