Don't fail in deleteIfManaged when the namespace/project is not managed
#15688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aged. Instead, ignore the request silently. That seems to be the original intention based on the usage of the method everywhere else but the test suite 8-| Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
requested review from
amisevsk,
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
|
ci-build |
skabashnyuk
approved these changes
Jan 15, 2020
|
ci-test |
|
crw-ci-test |
sleshchenko
approved these changes
Jan 15, 2020
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Outdated
Show resolved
Hide resolved
sparkoo
reviewed
Jan 15, 2020
...c/main/java/org/eclipse/che/workspace/infrastructure/openshift/project/OpenShiftProject.java
Show resolved
Hide resolved
...c/main/java/org/eclipse/che/workspace/infrastructure/openshift/project/OpenShiftProject.java
Show resolved
Hide resolved
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Show resolved
Hide resolved
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Show resolved
Hide resolved
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Show resolved
Hide resolved
che-bot
added
status/code-review
amisevsk
approved these changes
Jan 15, 2020
.../java/org/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespace.java
Show resolved
Hide resolved
a namespace. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
Can one of the admins verify this patch? |
…tempt-to-delete-non-managed-namespace Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
I agree to the degree that I already filed an issue a couple of months ago :) - #15250 I think we should not embark on such a potentially big refactoring in a small bugfix like this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
crw-ci-test |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
vparfonov
pushed a commit
that referenced
this pull request
Jan 17, 2020
…aged (#15688) Don't fail in `deleteIfManaged` when the namespace/project is not managed. Instead, ignore the request silently. That seems to be the original intention based on the usage of the method everywhere else but the test suite 8-| Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't fail in
deleteIfManagedwhen the namespace/project is not managed.Instead, ignore the request silently.
That seems to be the original intention based on the usage of the method
everywhere else but the test suite 8-|
This bug manifested itself as unnecessary warnings about the inability to delete the namespace/project when a workspace was deleted.
What issues does this PR fix or reference?
#15686