Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail in deleteIfManaged when the namespace/project is not managed #15688

Merged
merged 4 commits into from
Jan 17, 2020
Merged

Don't fail in deleteIfManaged when the namespace/project is not managed #15688

merged 4 commits into from
Jan 17, 2020

Commits on Jan 14, 2020

  1. Don't fail in deleteIfManaged when the namespace/project is not man… 

    …aged.

Instead, ignore the request silently.

That seems to be the original intention based on the usage of the method
everywhere else but the test suite 8-|

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    9001156 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Increase the log level to inform about the reason for not deleting 

    a namespace.

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    212cd03 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into bug/15686-dont-at… 

    …tempt-to-delete-non-managed-namespace

Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    47d9291 View commit details
    Browse the repository at this point in the history

  3. Fix a typo. 

    Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
    @metlos
    metlos committed Jan 16, 2020
    Configuration menu
    Copy the full SHA
    c251274 View commit details
    Browse the repository at this point in the history