Disable http2 by default for java8 #16964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd higher as JDK9 which enables Http2 unsupported for JDK8. Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
metlos,
mshaposhnik,
sparkoo,
amisevsk and
sleshchenko
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
|
crw-ci-test |
|
ci-test |
skabashnyuk
commented
May 18, 2020
assembly/assembly-wsmaster-war/src/main/java/org/eclipse/che/api/deploy/WsMasterModule.java
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
metlos
previously approved these changes
May 18, 2020
metlos
reviewed
May 18, 2020
assembly/assembly-wsmaster-war/src/main/java/org/eclipse/che/api/deploy/WsMasterModule.java
Outdated
Show resolved
Hide resolved
…8u251 and higher as JDK9 which enables Http2 unsupported for JDK8. Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
metlos
approved these changes
May 18, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
mkuznyetsov
pushed a commit
that referenced
this pull request
May 19, 2020
* Disable http2 by default for java8. OkHttp wrongly detects JDK8u251 and higher as JDK9 which enables Http2 unsupported for JDK8. Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disable http2 by default for java8. OkHttp wrongly detects JDK8u251 and higher as JDK9 which enables Http2 unsupported for JDK8.
What issues does this PR fix or reference?
Workaround for #16944