Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable http2 by default for java8 #16964

Merged
merged 2 commits into from
May 18, 2020
Merged

Disable http2 by default for java8 #16964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a02f428
Disable http2 by default for java8. OkHttp wrongly detects JDK8u251 a…
skabashnyuk May 18, 2020
db500db
fixup! Disable http2 by default for java8. OkHttp wrongly detects JDK…
skabashnyuk May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions assembly/assembly-wsmaster-war/src/main/java/org/eclipse/che/api/deploy/WsMasterModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ public class WsMasterModule extends AbstractModule {

@Override
protected void configure() {
// Workaround for https://github.com/fabric8io/kubernetes-client/issues/2212
// OkHttp wrongly detects JDK8u251 and higher as JDK9 which enables Http2 unsupported for JDK8.
// Can be removed after upgrade to Fabric8 4.10.2 or higher or to Java 11
if (System.getProperty("java.version", "").startsWith("1.8")) {
System.setProperty("http2.disable", "true");
skabashnyuk marked this conversation as resolved.
Show resolved Hide resolved
}

// db related components modules
install(new org.eclipse.che.account.api.AccountModule());
install(new org.eclipse.che.api.ssh.server.jpa.SshJpaModule());
Expand Down