NPE in ExternalContextImpl.encodeRedirectURL when no ViewRoot availab… #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjantijms @BalusC @manfredriem could you please merge this ASAP? |
BalusC
approved these changes
Jan 20, 2024
|
Merged but please note that this PR is on master branch not on 4.0 branch. You'll need to create a separate PR for 4.0 branch. |
|
Can you merge to 4.0 pls? |
|
You can't merge backwards in versions. In order to maintain a consistent revision history, you can only merge upwards in versions (e.g. first PR for 2.3 then simply merge into 3.0 then 4.0 then 4.1 then master (5.0)). But leave it, I made another PR for 4.0 whereby I reviewed and cleaned up all this logic: #5385, see also the main ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5383
FacesContextImpl: encodeRedirectURL accesses FacesContext.ViewRoot.attributes w/o checking, if ViewRoot has been set already
This causes NullPointerException and so failure of the request