#5383 cleanup facelets encoding management #5385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalusC
changed the title
This was referenced Jan 20, 2024
BalusC
deleted the
mojarra_issue_5383_cleanup_facelets_encoding_management
branch
TomasHofman
reviewed
Mar 26, 2024
|
|
||
| if (encoding == null) { | ||
| // 5. If still none found then fall back to specified default. | ||
| encoding = defaultEncoding.get(); |
There was a problem hiding this comment.
This is calling Optional.get() without checking emptiness, and the line 1629 is actually passing an empty Optional, resulting in NoSuchElementException: No value present.
Causing failures in Jakarta TCK:
Caused by: java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:143)
at jakarta.faces.impl@4.0.6.redhat-00001//com.sun.faces.util.Util.getResponseEncoding(Util.java:1680)
at jakarta.faces.impl@4.0.6.redhat-00001//com.sun.faces.util.Util.getResponseEncoding(Util.java:1629)
at jakarta.faces.impl@4.0.6.redhat-00001//com.sun.faces.application.view.MultiViewHandler.getRedirectURL(MultiViewHandler.java:350)
at jakarta.faces.impl@4.0.6.redhat-00001//jakarta.faces.application.ViewHandlerWrapper.getRedirectURL(ViewHandlerWrapper.java:278)
at org.jboss.as.jsf-injection//org.jboss.weld.module.jsf.ConversationAwareViewHandler.getRedirectURL(ConversationAwareViewHandler.java:149)
at jakarta.faces.impl@4.0.6.redhat-00001//jakarta.faces.application.NavigationCase.getRedirectURL(NavigationCase.java:171)
at com.sun.ts//com.sun.ts.tests.jsf.api.jakarta_faces.application.navigationcase.TestServlet.navigationCaseGetRedirectURLTest(TestServlet.java:119)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.sun.ts//com.sun.ts.tests.jsf.common.servlets.HttpTCKServlet.invokeTest(HttpTCKServlet.java:163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5383
Review/cleanup/refactor all code logic related to managing facelets/request/response encoding and centralized in a new
Util#getResponseEncoding()method.Also took the opportunity to get rid of all hardcoded strings representing
"UTF-8"throughout the source code and replace them byStandardCharsets.UTF_8(.name())