Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSP compilation depends on the org.eclipse.jdt.core.compiler package #312

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

merks
Copy link
Contributor

@merks merks commented Sep 15, 2023

Add an include of the org.eclipse.jdt.core.compiler.batch plugin to the org.eclipse.equinox.sdk feature.

eclipse-platform/eclipse.platform.releng.aggregator#1251

Add an include of the org.eclipse.jdt.core.compiler.batch plugin to the
org.eclipse.equinox.sdk feature.

eclipse-platform/eclipse.platform.releng.aggregator#1251
@github-actions
Copy link

Test Results

     24 files  ±0       24 suites  ±0   12m 18s ⏱️ +57s
2 150 tests ±0  2 105 ✔️ ±0  44 💤 ±0  1 ±0 
2 194 runs  ±0  2 149 ✔️ ±0  44 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 17b922a. ± Comparison against base commit 1a51ae9.

@iloveeclipse
Copy link
Member

iloveeclipse commented Sep 15, 2023

Ed, few questions:

  • org.eclipse.jdt.core.compiler.batch is also included in org.eclipse.jdt feature. Should it be removed there?
  • why org.eclipse.equinox.sdk needs org.eclipse.jdt.core.compiler.batch? Wasn't jsp thing required in the "help" / org.eclipse.platform?

@merks
Copy link
Contributor Author

merks commented Sep 15, 2023

The JSP thing is provided by

Ed, few questions:

* org.eclipse.jdt.core.compiler.batch is also included in org.eclipse.jdt feature. Should it be removed there?

No I think it belongs in the JDT feature.

* why org.eclipse.equinox.sdk needs org.eclipse.jdt.core.compiler.batch? Wasn't jsp thing required in the "help" / org.eclipse.platform?

The help system uses the JSP support from Equinox:

image

And the newer JSP compilers use JDT's batch compiler.

@iloveeclipse iloveeclipse merged commit f20db02 into eclipse-equinox:master Sep 15, 2023
@merks merks deleted the issue-1251-jdt-compiler branch September 15, 2023 07:50
@laeubi
Copy link
Member

laeubi commented Sep 18, 2023

Can't we activate to include all dependencies in the SDK or do we need to explicitly manage each item separately?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants