-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is org.apache.jasper.glassfish actually required? #1251
Comments
If the help system still works without org.apache.jasper.glassfish (aka jsp files are getting compiled and render after that) you can remove it. IIRC @mickaelistria tried to replace it but it was not working. |
The short answer is that currently it is required. The long answer is that with some small effort it can be replaced the following: https://repo1.maven.org/maven2/org/eclipse/jetty/apache-jsp/10.0.15/apache-jsp-10.0.15.pom But firstly we have to make sure the requirements of that are satisfied and that's not the case with the current contents of the target platform We need these:
We also have to be wary of all the places the name bundle symbolic name is hard coded: To get it working with the newer dependencies, we have to allow newer versions and com.sun.el is needed: The specialized class loader needs to be able to load com.sun.el.EpxressionFactory: And finally the servlet needs to initialize Jasper The older include can be removed from here: /org.eclipse.help-feature/feature.xml And then the help system works: I'm not sure if it's appropriate to make these changes immediately. Perhaps we'll have to wait for 2023-12 m1? |
Help systems jsp support is extremely fragile so please keep it for M1. Also I do believe that an effort to move to Jetty 12 (https://www.eclipse.org/lists/jetty-announce/msg00177.html) with EE 8 should be done prior or toghether with that as that would open the door for switching the EE implementation without changing major Jetty version. |
FYI, looking here: versus here:
the JSP support seems not to be present: https://repo1.maven.org/maven2/org/eclipse/jetty/apache-jsp/ So I don't yet see an upgrade path via 12.x.. |
That's because Jetty 12 is independent of EE version and one can switch between EE 8 (https://repo1.maven.org/maven2/org/eclipse/jetty/ee8/jetty-ee8-bom/12.0.0/jetty-ee8-bom-12.0.0.pom), EE 9 (https://repo1.maven.org/maven2/org/eclipse/jetty/ee9/jetty-ee9-bom/12.0.0/jetty-ee9-bom-12.0.0.pom) and EE 10 (https://repo1.maven.org/maven2/org/eclipse/jetty/ee10/jetty-ee10-bom/12.0.0/jetty-ee10-bom-12.0.0.pom) . |
I see!Not sure version of the dependency is specified when no version is specified. The largest I guess: Oh well, stuff to revisit in September... Thanks for sharing your insights! |
I tried to remove it a while ago in #774 , but gave up. Not sure whether the reasons still apply with newer versions of other deps. |
I think I can get JSP working with newer dependencies as described here: But I don't have the capacity to try to migrate everything to Jetty 12.x. So should I do the smaller step for now, or should I just leave the whole thing for someone to do the Jetty 12.x work eventually? |
Whatever can be done now is better than waiting for big bang changes IMHO. |
Replace some with org.mortbay.jasper.apache-jsp. eclipse-platform#1251
I see the nightly I-Build fails like this:
This suggests that org.eclipse.jdt.core.compiler.batch is needed in the org.eclipse.equinox.sdk feature: One might have expected Tycho to have resolved that package import... |
Add an include of the org.eclipse.jdt.core.compiler.batch plugin to the org.eclipse.equinox.sdk feature. eclipse-platform/eclipse.platform.releng.aggregator#1251
Aren't we discussing removal of org.eclipse.equinox.sdk.product in #1235 ? |
That may be. But the build is broken and it appears that the Equinox SDK feature is "incomplete", at least as far as inclusion in a product is concern... |
Fully agree. I'm going to merge eclipse-equinox/equinox#312 & start an I-Build. |
Add an include of the org.eclipse.jdt.core.compiler.batch plugin to the org.eclipse.equinox.sdk feature. eclipse-platform/eclipse.platform.releng.aggregator#1251
Replace some with org.mortbay.jasper.apache-jsp. #1251
I created an installation using the installer based on the just-completed I-Build from today. The help system is working: So I think we're in pretty reasonable shape... Hopefully there are only test issues to iron out; or better yet, hopefully there are none of those! |
For this build I see all the UA tests pass for this: Including the org.eclipse.ua.tests.help.webapp.HelpServerInterrupt and the org.eclipse.ua.tests.help.webapp.HelpServerBinding tests, which were the ones failing for the PR build. I'll need to key an eye on these when they are done, but it's looking promising: https://download.eclipse.org/eclipse/downloads/drops4/I20230915-0750/testResults.php |
I've been trying to eliminate bundles in the target platform from old cvs-based orbit builds.
Looking at SimRel, the only strict requirement on org.apache.jasper.glassfish is the inclusion in the help feature:
Looking at what the bundle provides we see two dependencies on the exported packages:
But if we look at that package requirement
it's also satisfied by org.glassfish.web.javax.servlet.jsp /2.3.4
And that's already in the target platform:
So I think we can remove this now and remove the inclusion in the feature
@akurtakov
Or is there something I've overlooked?
The text was updated successfully, but these errors were encountered: