Prevent trust dialogs from being hidden behind the application window

Use SWT.ON_TOP for the shell in order to keep the dialogs visible, because generally the user cannot proceed with their activity (update/install) until the dialog is completed. A modal dialog is avoided because these dialogs are asynchronously opened from a background job, which blocks, so there is no knowing what UI activity might currently be under way. eclipse-oomph/oomph#11
eclipse-equinox · Oct 12, 2023 · bc8eb82 · bc8eb82
1 parent 48e7f27
commit bc8eb82
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...se.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustAuthorityDialog.java b/...se.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustAuthorityDialog.java
@@ -83,7 +83,7 @@ public class TrustAuthorityDialog extends SelectionDialog {
 	public TrustAuthorityDialog(Shell parentShell, Object input) {
 		super(parentShell);
 
-		setShellStyle(SWT.DIALOG_TRIM | SWT.MODELESS | SWT.RESIZE | SWT.MAX | getDefaultOrientation());
+		setShellStyle(SWT.DIALOG_TRIM | SWT.MODELESS | SWT.RESIZE | SWT.MAX | SWT.ON_TOP | getDefaultOrientation());
 
 		if (input instanceof TreeNode[] nodes) {
 			init(null, nodes);

diff --git a/....equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java b/....equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/TrustCertificateDialog.java
@@ -82,7 +82,7 @@ public class TrustCertificateDialog extends SelectionDialog {
 	public TrustCertificateDialog(Shell parentShell, Object input) {
 		super(parentShell);
 
-		setShellStyle(SWT.DIALOG_TRIM | SWT.MODELESS | SWT.RESIZE | SWT.MAX | getDefaultOrientation());
+		setShellStyle(SWT.DIALOG_TRIM | SWT.MODELESS | SWT.RESIZE | SWT.MAX | SWT.ON_TOP | getDefaultOrientation());
 
 		if (input instanceof TreeNode[]) {
 			init(null, (TreeNode[]) input);