"Trust Artifacts" dialog not modal #11
Comments
|
Yes, I've had that happen too, though in the Progress dialog in the IDE. In any case, this would need to change in p2:
|
|
While I would like to make the dialog modal, doing so would affect not just the installer's use of it. There is always a risk that a dialog such as this one that opens at some arbitrary time driven by a background job might appear while some other modal dialog/interaction is in progress. Maybe I can do something that affects only the installer, e.g., looking for dialog shells when the installer shell is activated... |
|
I have a feeling that these dialogs could use SWT.ON_TOP rather than making them modal... |
merks
added a commit
to merks/p2
that referenced
this issue
Oct 12, 2023
Use SWT.ON_TOP for the shell in order to keep the dialogs visible, because generally the user cannot proceed with their activity (update/install) until the dialog is completed. A modal dialog is avoided because these dialogs are asynchronously opened from a background job, which blocks, so there is no knowing what UI activity might currently be under way. eclipse-oomph/oomph#11
merks
added a commit
to eclipse-equinox/p2
that referenced
this issue
Oct 12, 2023
Use SWT.ON_TOP for the shell in order to keep the dialogs visible, because generally the user cannot proceed with their activity (update/install) until the dialog is completed. A modal dialog is avoided because these dialogs are asynchronously opened from a background job, which blocks, so there is no knowing what UI activity might currently be under way. eclipse-oomph/oomph#11
|
After running into this twice this week, I decided to take action. 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
it can hide behind the Eclipse Installer Window, which look and feels like program is stuck:
The text was updated successfully, but these errors were encountered: