Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[null] Incomplete handling of @NonNullByDefault #682

Closed
stephan-herrmann opened this issue Jan 31, 2023 · 0 comments · Fixed by #683
Closed

[null] Incomplete handling of @NonNullByDefault #682

stephan-herrmann opened this issue Jan 31, 2023 · 0 comments · Fixed by #683
Assignees
@stephan-herrmann

Comments

@stephan-herrmann
Copy link
Contributor

In bug 522142 two bugs were reported indicating that

  • redundant explicit @NonNull within the scope of @NonNullByDefault is not always reported
  • @NonNullByDefault may be evaluated "too late" to have its desired effect

More related open bugs:

Let's see how much I can resolved by one combined PR.
@stephan-herrmann stephan-herrmann self-assigned this Jan 31, 2023
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Jan 31, 2023
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682
7f51d80 
+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ new tests from Bugs 522142 and 499596
@stephan-herrmann stephan-herrmann linked a pull request Jan 31, 2023 that will close this issue
[null] Incomplete handling of @NonNullByDefault - fixes #682 #683
Merged
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Feb 1, 2023
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682
0479e6a 
+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ new tests from Bugs 522142 and 499596
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Feb 1, 2023
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682
e51dcd5 
+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ new tests from Bugs 522142 and 499596
stephan-herrmann added a commit to stephan-herrmann/eclipse.jdt.core that referenced this issue Feb 1, 2023
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682
422a9b5 
+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ ignore newly reported warnings in other tests:
  - IncrementalTests18.testBug483744_remove
  - ExternalAnnotations18Test (several)
+ new tests from Bugs 522142 and 499596
stephan-herrmann added a commit that referenced this issue Feb 2, 2023
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes #682 (#683)
68f4603 
+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ ignore newly reported warnings in other tests:
  - IncrementalTests18.testBug483744_remove
  - ExternalAnnotations18Test (several)
+ new tests from Bugs 522142 and 499596
@srikanth-sankaran srikanth-sankaran mentioned this issue May 22, 2023
Closed
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this issue Jul 18, 2024
@stephan-herrmann
[null] Incomplete handling of @NonNullByDefault - fixes eclipse-jdt#682…
dd9ad78 
… (eclipse-jdt#683)

+ applying @NNBD to a type parameter needs to know, whether on demand
  resolving has already happened (to detect explicit null annotations)
  - ASTNode.resolveAnnotations
  - STB.maybeMarkTypeParametersNonNull
+ better distinction if null tag bits result from @NNBD or explicit anno
  - ASTNode.mergeAnnotationsIntoType
    - may now report redundance
    - fix withdrawal of contradiction null annots after these changes
+ more detection of redundance below @NNBD
  - TypeParameter.resolveAnnotations
  - TypeReference.resolveAnnotations - one focus on annots on dimensions
  - MethodBinding.fillInDefaultNonNullness18 - less reporting here
  - ProblemReporter.nullAnnotationIsRedundant
    - 2 more overloads
    - fine tuning of error positions
+ be careful not to apply @NNBD to typevar (when using TYPE_USE)
  - new methods {Scope,STB}.hasDefaultNullnessForType()
+ expect redundance warning in may more tests
  - NullTypeAnnotationTest
  - NullAnnotationBatchCompilerTest
+ ignore newly reported warnings in other tests:
  - IncrementalTests18.testBug483744_remove
  - ExternalAnnotations18Test (several)
+ new tests from Bugs 522142 and 499596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephan-herrmann stephan-herrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[null] Incomplete handling of @NonNullByDefault - fixes #682 stephan-herrmann/eclipse.jdt.core
1 participant
@stephan-herrmann