[null] Incomplete handling of @NonNullByDefault - fixes #682 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephan-herrmann
commented
Jan 31, 2023
stephan-herrmann
commented
- applying @NNBD to a type parameter needs to know, whether on demand resolving has already happened (to detect explicit null annotations)
- ASTNode.resolveAnnotations
- STB.maybeMarkTypeParametersNonNull
- better distinction if null tag bits result from @NNBD or explicit anno
- ASTNode.mergeAnnotationsIntoType - may now report redundance
- fix withdrawal of contradiction null annots after these changes
- more detection of redundance below @NNBD
- TypeParameter.resolveAnnotations
- TypeReference.resolveAnnotations - one focus on annots on dimensions
- MethodBinding.fillInDefaultNonNullness18 - less reporting here
- ProblemReporter.nullAnnotationIsRedundant
- 2 more overloads
- fine tuning of error positions
- be careful not to apply @NNBD to typevar (when using TYPE_USE)
- new methods {Scope,STB}.hasDefaultNullnessForType()
- expect redundance warning in may more tests
- NullTypeAnnotationTest
- NullAnnotationBatchCompilerTest
- new tests from Bugs 522142 and 499596
stephan-herrmann
force-pushed
the
issue682
branch
2 times, most recently
from
0479e6a
to
e51dcd5
Compare
+ applying @NNBD to a type parameter needs to know, whether on demand resolving has already happened (to detect explicit null annotations) - ASTNode.resolveAnnotations - STB.maybeMarkTypeParametersNonNull + better distinction if null tag bits result from @NNBD or explicit anno - ASTNode.mergeAnnotationsIntoType - may now report redundance - fix withdrawal of contradiction null annots after these changes + more detection of redundance below @NNBD - TypeParameter.resolveAnnotations - TypeReference.resolveAnnotations - one focus on annots on dimensions - MethodBinding.fillInDefaultNonNullness18 - less reporting here - ProblemReporter.nullAnnotationIsRedundant - 2 more overloads - fine tuning of error positions + be careful not to apply @NNBD to typevar (when using TYPE_USE) - new methods {Scope,STB}.hasDefaultNullnessForType() + expect redundance warning in may more tests - NullTypeAnnotationTest - NullAnnotationBatchCompilerTest + ignore newly reported warnings in other tests: - IncrementalTests18.testBug483744_remove - ExternalAnnotations18Test (several) + new tests from Bugs 522142 and 499596
stephan-herrmann
force-pushed
the
issue682
branch
from
e51dcd5
to
422a9b5
Compare
|
A version bump is needed as can be seen at https://download.eclipse.org/eclipse/downloads/drops4/I20230202-1800/buildlogs/reporeports/reports/versionChecks.html :
|
stephan-herrmann
added a commit
to stephan-herrmann/eclipse.jdt.core
that referenced
this pull request
Feb 4, 2023
stephan-herrmann
added a commit
to stephan-herrmann/eclipse.jdt.core
that referenced
this pull request
Feb 4, 2023
stephan-herrmann
added a commit
that referenced
this pull request
Feb 4, 2023
stephan-herrmann
added a commit
to stephan-herrmann/eclipse.jdt.core
that referenced
this pull request
Feb 6, 2023
iloveeclipse
pushed a commit
that referenced
this pull request
Feb 7, 2023
3 tasks
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
… (eclipse-jdt#683) + applying @NNBD to a type parameter needs to know, whether on demand resolving has already happened (to detect explicit null annotations) - ASTNode.resolveAnnotations - STB.maybeMarkTypeParametersNonNull + better distinction if null tag bits result from @NNBD or explicit anno - ASTNode.mergeAnnotationsIntoType - may now report redundance - fix withdrawal of contradiction null annots after these changes + more detection of redundance below @NNBD - TypeParameter.resolveAnnotations - TypeReference.resolveAnnotations - one focus on annots on dimensions - MethodBinding.fillInDefaultNonNullness18 - less reporting here - ProblemReporter.nullAnnotationIsRedundant - 2 more overloads - fine tuning of error positions + be careful not to apply @NNBD to typevar (when using TYPE_USE) - new methods {Scope,STB}.hasDefaultNullnessForType() + expect redundance warning in may more tests - NullTypeAnnotationTest - NullAnnotationBatchCompilerTest + ignore newly reported warnings in other tests: - IncrementalTests18.testBug483744_remove - ExternalAnnotations18Test (several) + new tests from Bugs 522142 and 499596
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.