-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move folder to jdt.core.manipulations; Replace plugin-specific references #810
Conversation
676075b
to
6a42628
Compare
/rebase |
Hi @robstryker There was another change to ExtractTempRefactoring just merged. You'll need to handle the conflicts above. I fixed the build problem so it should build. |
…nces Signed-off-by: Rob Stryker <stryker@redhat.com>
6a42628
to
6276d34
Compare
@mickaelistria changed the o.e.resources api to use generics and this has broken the build via 9 warnings about generic typesafety. I will need to fix that first. |
Signed-off-by: Rob Stryker <stryker@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
FYI: this caused SDK build failure, see eclipse-platform/eclipse.platform#716. |
This PR caused us to have split packages for the following:
The following classes remain in
I assume these classes could not move to Something like:
|
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation PDE removed unused attributes of feature.xml in eclipse-pde/eclipse.pde#770 Fixes eclipse-m2e#1591
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation PDE removed unused attributes of feature.xml in eclipse-pde/eclipse.pde#770 Fixes eclipse-m2e#1591
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation PDE removed unused attributes of feature.xml in eclipse-pde/eclipse.pde#770 Fixes #1591
What it does
This patch moves a significant number of refactor classes into jdt manipulations. Twelve previous PRs have been building to this patch, moving dependency classes and small bits of logic around to prepare for this.
By having the refactor operations available in jdt manipulations, they will be availalable to non-UI consumers such as vscode-java / jdt.ls.
How to test
Author checklist