Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move folder to jdt.core.manipulations; Replace plugin-specific references #810

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

robstryker
Copy link
Contributor

@robstryker robstryker commented Sep 20, 2023

What it does

This patch moves a significant number of refactor classes into jdt manipulations. Twelve previous PRs have been building to this patch, moving dependency classes and small bits of logic around to prepare for this.

By having the refactor operations available in jdt manipulations, they will be availalable to non-UI consumers such as vscode-java / jdt.ls.

How to test

Author checklist

@jjohnstn
Copy link
Contributor

/rebase

@jjohnstn
Copy link
Contributor

Hi @robstryker There was another change to ExtractTempRefactoring just merged. You'll need to handle the conflicts above. I fixed the build problem so it should build.

…nces

Signed-off-by: Rob Stryker <stryker@redhat.com>
@robstryker
Copy link
Contributor Author

@mickaelistria changed the o.e.resources api to use generics and this has broken the build via 9 warnings about generic typesafety. I will need to fix that first.

Signed-off-by: Rob Stryker <stryker@redhat.com>
@jjohnstn jjohnstn self-requested a review September 21, 2023 19:40
Copy link
Contributor

@jjohnstn jjohnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jjohnstn jjohnstn merged commit 5899c4e into eclipse-jdt:master Sep 21, 2023
7 checks passed
@jjohnstn jjohnstn added this to the 4.30 M1 milestone Sep 21, 2023
@iloveeclipse
Copy link
Member

FYI: this caused SDK build failure, see eclipse-platform/eclipse.platform#716.

@tjwatson
Copy link
Contributor

This PR caused us to have split packages for the following:

org.eclipse.jdt.internal.corext.refactoring.reorg
org.eclipse.jdt.internal.corext.refactoring

The following classes remain in org.eclipse.jdt.ui

org/eclipse/jdt/internal/corext/refactoring/reorg/ReorgUtils.class
org/eclipse/jdt/internal/corext/refactoring/reorg/JavaElementTransfer.class
org/eclipse/jdt/internal/corext/refactoring/RefactoringAvailabilityTester.class
org/eclipse/jdt/internal/corext/refactoring/RefactoringExecutionStarter.class

I assume these classes could not move to org.eclipse.jdt.core.manipulation for good reason? If so then we need to put some additional meta-data on the exports of these packages from org.eclipse.jdt.core.manipulation similar to how the org.eclipse.core.runtime split package is exported from org.eclipse.equinox.registry:

https://github.com/eclipse-equinox/equinox/blob/7eb1b42156e06225670c1c61cf351f805d5bbd13/bundles/org.eclipse.equinox.registry/META-INF/MANIFEST.MF#L11

Something like:

Export-Package: org.eclipse.jdt.internal.corext.refactoring; jdt.core=split;mandatory:=jdt.core,
 org.eclipse.jdt.internal.corext.refactoring.reorg; jdt.core=split;mandatory:=jdt.core,

HannesWell added a commit to HannesWell/m2e-core that referenced this pull request Nov 7, 2023
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT
moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation

PDE removed unused attributes of feature.xml in
eclipse-pde/eclipse.pde#770

Fixes eclipse-m2e#1591
HannesWell added a commit to HannesWell/m2e-core that referenced this pull request Nov 7, 2023
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT
moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation

PDE removed unused attributes of feature.xml in
eclipse-pde/eclipse.pde#770

Fixes eclipse-m2e#1591
HannesWell added a commit to eclipse-m2e/m2e-core that referenced this pull request Nov 8, 2023
JDT moved in eclipse-jdt/eclipse.jdt.ui#810, JDT
moved classes from o.e.jdt.ui to o.e.jdt.core.manipulation

PDE removed unused attributes of feature.xml in
eclipse-pde/eclipse.pde#770

Fixes #1591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants