Mark newly split packages with mandatory directives #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring
jjohnstn
added a commit
that referenced
this pull request
Sep 28, 2023
* Revert "Mark newly split packages with mandatory directives (#833)" This reverts commit cd6cf28. * Revert "Javadoc error fix for CUCorrectionProposal.setDelegate()" This reverts commit 819ec65. * Revert "Fix FixCorrectionProposal to properly handle IMultiFix cleanups (#829)" This reverts commit 31839df. * Revert "Add back some missing methods to FixCorrectionProposal (#827)" This reverts commit 6f79122. * Revert "Proposals branch (#815)" This reverts commit 816a5d2. - fixes #835
jjohnstn
pushed a commit
to jjohnstn/eclipse.jdt.ui-1
that referenced
this pull request
Sep 29, 2023
The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 4, 2023
The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 9, 2023
The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 9, 2023
The manipulation bundle already marks other split packages with manipulation=split;mandatory:=manipulation This add the same thing to the newly split packages: org.eclipse.jdt.internal.corext.refactoring.reorg org.eclipse.jdt.internal.corext.refactoring
jjohnstn
pushed a commit
that referenced
this pull request
Oct 10, 2023
Revise the patch to refactor proposals logic into jdt.core.manipulation - split the proposal logic into core and U moving the vast majority of the logic into the core classes - maintain existing UI non-core classes as wrappers for stability. - create IInvocationContextCore class and makes it the default interface for use in the core classes - mark newly split packages with mandatory directives (#833) Signed-off-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Rob Stryker <stryker@redhat.com> Co-authored-by: Jeff Johnston <jjohnstn@redhat.com> Co-authored-by: Andrey Loskutov <loskutov@gmx.de> Co-authored-by: Thomas Watson <tjwats@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up meta-data for newly split packages introduced by PR #810