Fix FixCorrectionProposal to properly handle IMultiFix cleanups #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping
jjohnstn
added a commit
to jjohnstn/eclipse.jdt.ui-1
that referenced
this pull request
Sep 27, 2023
…ps (eclipse-jdt#829)" This reverts commit 31839df.
jjohnstn
added a commit
that referenced
this pull request
Sep 28, 2023
* Revert "Mark newly split packages with mandatory directives (#833)" This reverts commit cd6cf28. * Revert "Javadoc error fix for CUCorrectionProposal.setDelegate()" This reverts commit 819ec65. * Revert "Fix FixCorrectionProposal to properly handle IMultiFix cleanups (#829)" This reverts commit 31839df. * Revert "Add back some missing methods to FixCorrectionProposal (#827)" This reverts commit 6f79122. * Revert "Proposals branch (#815)" This reverts commit 816a5d2. - fixes #835
jjohnstn
added a commit
to jjohnstn/eclipse.jdt.ui-1
that referenced
this pull request
Sep 29, 2023
…pse-jdt#829) - new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 4, 2023
…pse-jdt#829) - new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 9, 2023
…pse-jdt#829) - new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping
robstryker
pushed a commit
to robstryker/eclipse.jdt.ui
that referenced
this pull request
Oct 9, 2023
…pse-jdt#829) - new split of proposals into jdt.core.manipulation changed the computeNumberOfFixesForCleanUp() method to be passed an ICleanUpCore that is wrappered to be an ICleanUp but this code looks for an IMultiFix which gets lost in wrapping - change computeNumberOfFixesForClean() to use the fCleanUp field that is already stored and is an ICleanUp - fix getCleanUp() to return fCleanUp - fix AbstractAnnotationHover.createCompletionProposalsList() to just call proposal.getCleanUp() and don't do any wrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes regression so multiple NLS fixes will be offered for the whole file.
How to test
See issue.
Author checklist