Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maven.multiModuleProjectDirectory property #2976

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add maven.multiModuleProjectDirectory property #2976

merged 1 commit into from
Nov 24, 2023

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Nov 22, 2023

@snjeza snjeza mentioned this pull request Nov 22, 2023
Closed
@rgrunber rgrunber added this to the End November 2023 milestone Nov 22, 2023
@rgrunber rgrunber added the maven label Nov 22, 2023
@snjeza
Add maven.multiModuleProjectDirectory property
1fc6759 
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
rgrunber
rgrunber reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working. The value is set to null for a single module project but that seems expected.

....jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/StandardPreferenceManager.java Show resolved Hide resolved
@rgrunber rgrunber merged commit 4a4ddb8 into eclipse-jdtls:master Nov 24, 2023
7 checks passed
@snjeza
Copy link
Contributor Author

snjeza commented Nov 24, 2023

Seems to be working. The value is set to null for a single module project but that seems expected.

You may want to take a look at

the maven.multiModuleProjectDirectory is the first parent directory starting from the current executed module that has a .mvn folder so it could even be used if not executed from the root.

@rgrunber rgrunber mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber left review comments

@fbricon fbricon Awaiting requested review from fbricon

@jdneo jdneo Awaiting requested review from jdneo

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
maven
Projects
None yet
Milestone
End November 2023
Development

Successfully merging this pull request may close these issues.

Question: Is multi-module maven projects compiled using multiple threads?
2 participants
@snjeza @rgrunber