maven.multiModuleProjectDirectory in <repositories> not resolved #666
Comments
GaZaTu
changed the title
|
Do I get it right the issue seems to be that |
|
I don't think it's expanded at all looking at this message in the exception: |
|
Do I get it right that this cause your project to be build-able only if starting it from its root; so it's basically not a modular build? |
|
@mickaelistria see https://maven.apache.org/docs/3.3.1/release-notes.html#jvm-and-command-line-options the Just as an reference here https://stackoverflow.com/questions/29778262/what-is-maven-multimoduleprojectdirectory-used-for it is is noted that
|
|
I'll provide a smol example project in a bit 😋 but to answer the question: the errors are visible when opening the root project and it is indeed a modular project. |
OK, thanks for clarifying. I see this variable is set by the MavenCli / CliRequest , that m2e doesn't use at all. So we'll need to replicate it. |
|
yes, but setting this will first require to have project specific |
|
I don't think we need project-specific Maven instance, but we need to improve how we build the MavenExecutionRequest to set this location when it's relevant. |
|
Possibly yes, when doing so it would be good to support maven.config and jvm.config as well see |
|
I can try to work on this one if it's OK with you.
Later, in another issue ;) |
|
Sure go a head, I just wanted to note that these two are very close related, once we have the |
This allows to read and set project-specific properties that can be passed to the Maven request and used for further executions. Covers parts of eclipse-m2e#666 and progress towards eclipse-m2e#546
This allows to read and set project-specific properties that can be passed to the Maven request and used for further executions. Covers parts of eclipse-m2e#666 and progress towards eclipse-m2e#546
|
@GaZaTu I've started to work on a patch that is likely to enable a lot of possible improvements, and even to fix the bug you mention. However, to be sure about the later, can you please share a minimal project that does reproduce the issue? |
This allows to read and set project-specific properties that can be passed to the Maven request and used for further executions. Covers parts of eclipse-m2e#666 and progress towards eclipse-m2e#546
This allows to read and set project-specific properties that can be passed to the Maven request and used for further executions. Covers parts of eclipse-m2e#666 and progress towards eclipse-m2e#546
|
@GaZaTu I merged a PR that is supposed to fix it. Please try updating to newer m2e snapshot in the next ~20 minutes and verify whether this is now working for you. |
|
uhh i'm sorry @mickaelistria i left work some time ago and don't have any build env / project at hand rn 😅. |
No need to be sorry for that, it's not some high emergency; enjoy your time away from work!
Please see https://github.com/eclipse-m2e/m2e-core/blob/master/CONTRIBUTING.md#-trying-latest-builds to get some instructions about installing latest snapshots. |
|
Should we close this and open dedicated issues if there is more work to do? |
|
Let's wait for @GaZaTu to verify it befotlre closing. |
|
idk what i'm doing wrong, i even downloaded a fresh eclipse-ide, but i just can't get this damn "Install new Software" dialog to open (which i assume is where i need to input |
|
@GaZaTu You seem to be unlucky here. Can you please try by downloading the Eclipse SDK from https://download.eclipse.org/eclipse/downloads/drops4/R-4.23-202203080310/ ? |
|
OK atleast i'm able to open the "Install new Software" dialog, but now i'm stuck trying to install I assume i need to install some other dependency before i install m2e but i have no idea which one/where to get it. Edit: nvm figured it out or rather just installed a bunch of others until it worked. |
|
On the Install Dialog, there is a "Manage Sites" button. Click it to add https://download.eclipse.org/releases/latest/ (which should contain most deps). Then try re-installing m2e. |
|
Looks like this issue is fixed, atleast i'm not getting any error messages anymore. |
Great, thanks for testing!
If you think it's worth it, please open a separate issue. |
|
Thanks 😋👌 |
yo,
i have a root pom.xml with an entry like this:
to provide all child maven modules with access to that in-project maven repo.
This works with IntelliJ and mvn-cli and used to work with Eclipse 2021-09 and redhat.java v1.1.0 but since updating to 2022-03 it results in an exception like this:
obscured GROUP_ID and ARTIFACT_ID
OS: openSUSE 15.1
IDE: both Eclipse 2022-03 and VSCode with redhat.java v1.5.0
The text was updated successfully, but these errors were encountered: