Replace lambda with method reference in SpringBootGenerator (#3371) #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryant-Tripathi
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #3443 (2024-10-14T16:06:39Z) ⚙️ JKube E2E Tests (11330970226)
|
|
Could you please check why build is failing on JDK8 ? |
|
Yes sure, @rohanKanojia checked with the issue and got error as: incompatible types: invalid method reference Attaching screenshot for reference:
|
|
@manusa @rohanKanojia Gentle ping, Do I need to proceed with suggestion ? |
manusa
requested changes
Oct 14, 2024
| @@ -84,7 +84,7 @@ public List<ImageConfiguration> customize(List<ImageConfiguration> configs, bool | |||
|
|
|||
| @Override | |||
| protected Map<String, String> getEnv(boolean prePackagePhase) { | |||
| return nestedGenerator.getEnv(ppp -> super.getEnv(ppp), prePackagePhase); | |||
| return nestedGenerator.getEnv(super::getEnv, prePackagePhase); | |||
There was a problem hiding this comment.
Apparently, the statement is incompatible with Java 8.
Let's just remove the warning and delay the refactoring to the future:
Suggested change
| return nestedGenerator.getEnv(super::getEnv, prePackagePhase); | |
| //TODO: Java8 compatibility, remove warning. Remove annotation once baseline is set to Java11+ | |
| //noinspection Convert2MethodRef | |
| return nestedGenerator.getEnv(ppp -> super.getEnv(ppp), prePackagePhase); |
…-with-method-reference
…rning
- Suppressed the Convert2MethodRef warning to avoid issues until the project baseline is upgraded to Java 11.
- Added a TODO comment to revisit and remove this workaround once the project moves to Java 11 or higher.
This ensures that the code remains compatible with Java 8 while avoiding unnecessary warnings.
…rning
- Suppressed the Convert2MethodRef warning to avoid issues until the project baseline is upgraded to Java 11.
- Added a TODO comment to revisit and remove this workaround once the project moves to Java 11 or higher.
This ensures that the code remains compatible with Java 8 while avoiding unnecessary warnings.
|
|
@manusa Updated with the suggestion :) |
rohanKanojia
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3371
Changes: