Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lambda with method reference in SpringBootGenerator (#3371) #3443

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Replace lambda with method reference in SpringBootGenerator (#3371) #3443

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7f870d
Replace lambda with method reference in SpringBootGenerator (#3371)
Aryant-Tripathi Oct 9, 2024
c944d4f
Merge branch 'eclipse-jkube:master' into 3371/refactor/replace-lambda…
Aryant-Tripathi Oct 14, 2024
66bfd22
fix: address Java 8 compatibility with suppressed method reference wa…
Aryant-Tripathi Oct 14, 2024
f32cccf
fix: address Java 8 compatibility with suppressed method reference wa…
Aryant-Tripathi Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...spring-boot/src/main/java/org/eclipse/jkube/springboot/generator/SpringBootGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public List<ImageConfiguration> customize(List<ImageConfiguration> configs, bool

@Override
protected Map<String, String> getEnv(boolean prePackagePhase) {
return nestedGenerator.getEnv(ppp -> super.getEnv(ppp), prePackagePhase);
return nestedGenerator.getEnv(super::getEnv, prePackagePhase);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, the statement is incompatible with Java 8.
Let's just remove the warning and delay the refactoring to the future:

Suggested change
return nestedGenerator.getEnv(super::getEnv, prePackagePhase);
//TODO: Java8 compatibility, remove warning. Remove annotation once baseline is set to Java11+
//noinspection Convert2MethodRef
return nestedGenerator.getEnv(ppp -> super.getEnv(ppp), prePackagePhase);

}

@Override
Expand Down