-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jvmtiGetThreadInfo to return correct thread group #16376
Conversation
@babsingh and @fengxue-IS Please review PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b695fe4
to
331027c
Compare
@dipak-bagadiya The line endings check is failing.
|
The jvmtiGetThreadInfo returns the invalid thread group in case of unstarted threads. A NULL targetThread indicates that the thread is either unstarted or terminated so this check is not sufficient to validate terminated threads. The boolean check is updated in jvmtiGetThreadInfo to return a valid thread group for unstarted threads. Fixes: eclipse-openj9#16226 Signed-off-by: Dipak Bagadiya <dipak.bagadiya@ibm.com>
331027c
to
d8acedf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jenkins test sanity zlinux jdk19 |
jenkins compile win jdk8 |
@dipak-bagadiya After this PR is merged, we can re-enable the test. The following exclude lines need to be removed:
Also, the @fengxue-IS I will be on vacation for the remainder of the week. Please assist Dipak if there are any doubts. |
jenkins test sanity amac jdk19 |
@pshipton @JasonFengJ9 @AdamBrousseau Are the below file system failures related to an infra issue?
|
jenkins test sanity xlinux jdk19 |
Unless that test cares about cleaning up the files, I would assume an infra issue. Folder is cleanup up on disk now. |
This looks like a machine/setup issue. |
There are quite a few errors in |
jenkins test sanity zlinux jdk19 |
Test had been fixed by- eclipse-openj9/openj9#16376 Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
Re-enable JTReg test thrinfo01 Test had been fixed by eclipse-openj9/openj9#16376 Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com
The jvmtiGetThreadInfo returns the invalid thread group in case of unstarted threads. A NULL targetThread indicates that the thread is either unstarted or terminated so this check is not sufficient to validate terminated threads.
The boolean check is updated in jvmtiGetThreadInfo to return a valid thread group for unstarted threads.
Fixes: #16226
Signed-off-by: Dipak Bagadiya dipak.bagadiya@ibm.com