Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jvmtiGetThreadInfo to return correct thread group #16376

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix jvmtiGetThreadInfo to return correct thread group #16376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions runtime/jvmti/jvmtiThread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,13 @@ jvmtiGetThreadInfo(jvmtiEnv *env,
group = J9_JNI_UNWRAP_REFERENCE(vm->vthreadGroup);
}
} else {
/* For platform threads, a NULL vmthread indicates that a thread is terminated. */
if ((NULL != targetThread) && (NULL != threadHolder)) {
/* For platform threads, a NULL vmthread indicates that a thread is either unstarted or terminated.
* As per the JVMTI spec, the thread group should be NULL IFF the thread is terminated.
*/
if (((NULL != targetThread)
|| !(jboolean)J9VMJAVALANGTHREAD_STARTED(currentThread, threadObject))
&& (NULL != threadHolder)
) {
group = (j9object_t)J9VMJAVALANGTHREADFIELDHOLDER_GROUP(currentThread, threadHolder);
}
}
Expand Down