Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POM and product version changes for 4.29 release #1100

Closed
Tracked by #1089
MohananRahul opened this issue Jun 2, 2023 · 21 comments · Fixed by eclipse-platform/eclipse.platform.ui#806
Closed
Tracked by #1089

Comments

@MohananRahul
Copy link
Contributor

No description provided.

MohananRahul added a commit to MohananRahul/eclipse.jdt.core that referenced this issue Jun 6, 2023
MohananRahul added a commit to MohananRahul/eclipse.jdt.debug that referenced this issue Jun 6, 2023
deepika-u added a commit to deepika-u/eclipse.platform.swt that referenced this issue Jun 6, 2023
@laeubi
Copy link
Contributor

laeubi commented Jun 6, 2023

Actually we have an automation for this but the milestones seem not being promoted (yet?) therefore nothing has happened until now.

@MohananRahul
Copy link
Contributor Author

@laeubi Which milestones automation should work? latest 4.28 RC2a is promoted.

@laeubi
Copy link
Contributor

laeubi commented Jun 6, 2023

Look for example here:

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/milestones

I would expect Milestones for the 4.29 release like it is there for the 4.28), there is a jenkins job that creates these milestones across all repositories, and this triggers the automatic PR generation.

@MohananRahul
Copy link
Contributor Author

Look for example here:

https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/milestones

I would expect Milestones for the 4.29 release like it is there for the 4.28), there is a jenkins job that creates these milestones across all repositories, and this triggers the automatic PR generation.

Actually I don't have any access to add milestone to new issue or add milestone to exist issue.

@akurtakov
Copy link
Member

https://ci.eclipse.org/releng/job/create-milestones seems to be gone. Anyone has idea what happened?

@laeubi
Copy link
Contributor

laeubi commented Jun 7, 2023

You need to login first to see the job because it contains sensitive information, and you need to be approved for the job (I can still see the job after login).

@akurtakov
Copy link
Member

I'm logged in but I can't see it. Would you please add @iloveeclipse and me so we can run it when needed.

@sravanlakkimsetti
Copy link
Member

I'm logged in but I can't see it. Would you please add @iloveeclipse and me so we can run it when needed.

done

@akurtakov
Copy link
Member

Thanks!

@akurtakov
Copy link
Member

Milestones job completed and I confirm they exist in platform.text repo as an example.

@sravanlakkimsetti sravanlakkimsetti modified the milestone: 4.28 M1 Jun 7, 2023
@laeubi
Copy link
Contributor

laeubi commented Jun 7, 2023

Alright, the prepare workflow was triggered ut failed due to missing Maven 3.9 ... I'll take a look now.

sravanlakkimsetti pushed a commit to MohananRahul/eclipse.platform.releng.aggregator that referenced this issue Jun 7, 2023
sravanlakkimsetti added a commit that referenced this issue Jun 7, 2023
* POM and product version changes for 4.29 release

Tracked in
#1100

* removed move to 4.29 I build

* Update pom.xml

---------

Co-authored-by: Sravan Kumar Lakkimsetti <77106773+sravanlakkimsetti@users.noreply.github.com>
@sravanlakkimsetti
Copy link
Member

Closing

@HannesWell
Copy link
Member

Could you please verify that the master-builds of all eclipse tlp repos now succeeds?
For example for PDE the last master build is a failed one and from your change to update to the ne platform-parent-pom there could be at least one version bump necessary (I'm currently on vacation and don't have access to a computer and therefore can't verify myself).

Furthermore there used to be a commit that did some inital version-bumps in the beginning of each release cycle in PDE, done by the releng team.
I havn't noticed that yet, is that intentional?

@sravanlakkimsetti
Copy link
Member

Could you please verify that the master-builds of all eclipse tlp repos now succeeds? For example for PDE the last master build is a failed one and from your change to update to the ne platform-parent-pom there could be at least one version bump necessary (I'm currently on vacation and don't have access to a computer and therefore can't verify myself).

Furthermore there used to be a commit that did some inital version-bumps in the beginning of each release cycle in PDE, done by the releng team. I havn't noticed that yet, is that intentional?

Here is the bug for that #1125. We will need help on this one.

akurtakov added a commit to eclipse-platform/eclipse.platform.common that referenced this issue Jun 9, 2023
akurtakov added a commit to eclipse-platform/eclipse.platform.releng that referenced this issue Jun 9, 2023
mickaelistria pushed a commit to mickaelistria/eclipse.platform.ui that referenced this issue Oct 6, 2023
laeubi pushed a commit to laeubi/eclipse.pde that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants