Move more product configuration from p2.inf to product-file #1459
Conversation
|
This looks very promising ! |
| @@ -194,6 +194,13 @@ United States, other countries, or both. | |||
| <property name="org.eclipse.update.reconcile" value="false" /> | |||
| <property name="eclipse.buildId" value="${unqualifiedVersion}.${buildQualifier}" /> | |||
| <property name="osgi.bundles.defaultStartLevel" value="4" /> | |||
| <property name="osgi.instance.area.default" value="@user.home/workspace" /> | |||
There was a problem hiding this comment.
IIRC, EPP uses eclipse-workspace here. Should we also change it for SDK products?
There was a problem hiding this comment.
Do you mean that the default suggestion for the workspace should be co-located to the installation?
Yes that's something I would also support. I always annoys me if I download an SDK to test something out that I first have to define the test workspace to be somewhere else than in such prominent location.
I'll create a follow-up PR on this so that we can discuss that then.
There was a problem hiding this comment.
No, I don't think he means that. Me means it's specified like this:
-Dosgi.instance.area.default=@user.home/eclipse-workspace
I think co-locating it with the installation you have to be careful it's not a read-only installation; maybe you'd co-located it relative to the installation surrogate but might even end up with a read-only location...
And remove the unnecessary specification of the property org.eclipse.equinox.p2.type.product=true, which Tycho/P2 already set by default.
HannesWell
force-pushed
the
unifyProductConfiguration
branch
from
251599d
to
bcdad78
Compare
|
I checked the newly build metadata and everything looks good. I'll merge this now and check tonight's I-build tomorrow if everything still works as expected. |
And remove the unnecessary specification of the property
org.eclipse.equinox.p2.type.product=true, which Tycho/P2 already set bydefault.
Additionally unify max-memory launcher-arguments of Platform/SDK products
P2 and Tycho 4.0.4 already support names for Product Update repositories with
but I think it is good to not submit this before PDE has Editor support for that as well as described in eclipse-equinox/p2#345.
A similar simplification can then also be applied to all EPP packages.