Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Product Update-site names #2929

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

HannesWell
Copy link
Member

This a work-around to have eclipse-equinox/p2#353 available now and can be reverted once the mentioned change in P2 is available in Tycho.
The reason for this is that I would like to use name-support in the product-definition already for the 2023-12 SimRel.
I'll take care about reverting this once the P2 updates for 2023-12 are available in Tycho.

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Test Results

   564 files  ±0     564 suites  ±0   4h 19m 2s ⏱️ - 31m 9s
   366 tests +1     360 ✔️ +1    6 💤 ±0  0 ±0 
1 098 runs  +3  1 079 ✔️ +3  19 💤 ±0  0 ±0 

Results for commit 954c96e. ± Comparison against base commit a9b7b40.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the updateSiteNames branch 4 times, most recently from e76119f to 67ec704 Compare October 21, 2023 08:35
@HannesWell
Copy link
Member Author

I just added a test-case and with that this is ready for me.

The test-case also needs to be added to the master branch, but I suggest to do that as part of the update to the next p2 release, which also allows to revert all implementation changes done in Tycho in this PR.

This a work-around to have
eclipse-equinox/p2#353 available now and can be
reverted once the mentioned change in P2 is available in Tycho.
@laeubi laeubi merged commit 486e6e4 into eclipse-tycho:tycho-4.0.x Oct 21, 2023
8 checks passed
@HannesWell HannesWell deleted the updateSiteNames branch October 21, 2023 15:18
HannesWell added a commit to HannesWell/tycho that referenced this pull request Dec 5, 2023
This also reverts the temporary changes of PublishProductToolImpl made
in eclipse-tycho#2929, which are obsolete
now that the new P2 version has support for names of update-sites built
in.
HannesWell added a commit to HannesWell/tycho that referenced this pull request Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made
in eclipse-tycho#2929, which are obsolete
now that the new P2 version has support for names of update-sites built
in.
HannesWell added a commit to HannesWell/tycho that referenced this pull request Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made
in eclipse-tycho#2929, which are obsolete
now that the new P2 version has support for names of update-sites built
in.
HannesWell added a commit that referenced this pull request Dec 9, 2023
This also reverts the temporary changes of PublishProductToolImpl made
in #2929, which are obsolete
now that the new P2 version has support for names of update-sites built
in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants