Make use proper assert functions in o.e.tips.tests... #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..using Text Blocks etc. by moving to Java 17
jukzi
reviewed
Jun 6, 2023
| assertTrue(!testTip.equals(fTip)); | ||
| assertTrue(testTip.equals(testTipx)); | ||
| assertNotNull(testTip); | ||
| assertEquals(testTip, testTip.equals(testTip)); |
There was a problem hiding this comment.
This is wrong! comparing boolean with Object.
|
@vrubezhny @akurtakov this causes regression: |
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform
that referenced
this pull request
Jan 22, 2024
This partly fixes initial bugs in the tests (as they have never been executed in CI builds) and partly fixes regressions from eclipse-platform/eclipse.platform.ua#90.
HeikoKlare
added a commit
to eclipse-platform/eclipse.platform
that referenced
this pull request
Jan 22, 2024
This partly fixes initial bugs in the tests (as they have never been executed in CI builds) and partly fixes regressions from eclipse-platform/eclipse.platform.ua#90.
Michael5601
pushed a commit
to CodeLtDave/eclipse.platform
that referenced
this pull request
Feb 12, 2024
This partly fixes initial bugs in the tests (as they have never been executed in CI builds) and partly fixes regressions from eclipse-platform/eclipse.platform.ua#90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..using Text Blocks etc. by moving to Java 17