Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active view/part indicator consistency in light theme #1651

Closed
thomasritter opened this issue Feb 6, 2024 · 0 comments · Fixed by #1652
Closed

Active view/part indicator consistency in light theme #1651

thomasritter opened this issue Feb 6, 2024 · 0 comments · Fixed by #1652
Labels
bug Something isn't working

Comments

@thomasritter
Copy link

When comparing the classic theme with the dark theme and the light theme it looks like the light theme is missing the blue indicator which highlights the currently active view/part.

Every theme should visually highlight:

  • Which view tab is currently shown in a section
  • Which view tab is overall currently selected in the IDE (Where is the focus? Where can I currently use my keyboard?)

Classic theme (Blue tab highlights currently selected view):
image

Dark theme (Blue underline highlights currently selected view):
image

Light theme (Tab gets rendered a little bit more grey but no blue underline indicator. Not consistent with dark theme.):
image

I would suggest to align the dark/light theme and add the blue underline to the light theme. From an accessibility standpoint only using such a small contrast is questionable. When looking at other IDEs (IntelliJ, VS Code) they increase tab contrast + add an indicator.

Tested under this environment:

  • OS & version: Mac Sonoma
  • Eclipse IDE/Platform version (as shown in Help > About): 20231201-2043
@thomasritter thomasritter added the bug Something isn't working label Feb 6, 2024
BeckerWdf added a commit to BeckerWdf/eclipse.platform.ui that referenced this issue Feb 7, 2024
@BeckerWdf
Add Active Part Indicator to Light Theme
6c256ee 
The dark theme already has such an indicator. It adds a blue underline
on the active tab.

This change aligns the dark/light theme and adds the blue underline
also to the light theme.

Fixes: eclipse-platform#1651
@BeckerWdf BeckerWdf mentioned this issue Feb 7, 2024
Merged
BeckerWdf added a commit to BeckerWdf/eclipse.platform.ui that referenced this issue Feb 7, 2024
@BeckerWdf
Add Active Part Indicator to Light Theme
476f8c8 
The dark theme already has such an indicator. It adds a blue underline
on the active tab.

This change aligns the dark/light theme and adds the blue underline
also to the light theme.

Fixes: eclipse-platform#1651
BeckerWdf added a commit to BeckerWdf/eclipse.platform.ui that referenced this issue Feb 8, 2024
@BeckerWdf
Add Active Part Indicator to Light Theme
13a18b7 
The dark theme already has such an indicator. It adds a blue underline
on the active tab.

This change aligns the dark/light theme and adds the blue underline
also to the light theme.

Fixes: eclipse-platform#1651
BeckerWdf added a commit that referenced this issue Feb 8, 2024
@BeckerWdf
Add Active Part Indicator to Light Theme
6d0c74a 
The dark theme already has such an indicator. It adds a blue underline
on the active tab.

This change aligns the dark/light theme and adds the blue underline
also to the light theme.

Fixes: #1651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Active Part Indicator to Light Theme BeckerWdf/eclipse.platform.ui
1 participant
@thomasritter