Add Active Part Indicator to Light Theme #1652
Conversation
|
This is how it looks like: The blue is not the same as in the dark theme. Actually I took the dark blue of the gradient that is used (on macOS) in the classic theme. |
|
@HeikoKlare: Would be great if you could find some time to test this on windows. |
Test Results 917 files + 611 917 suites +611 38m 5s ⏱️ + 22m 56s For more details on these failures, see this check. Results for commit 13a18b7. ± Comparison against base commit d7676d3. ♻️ This comment has been updated with latest results. |
BeckerWdf
force-pushed
the
active_tab_indicator
branch
from
6c256ee
to
476f8c8
Compare
The dark theme already has such an indicator. It adds a blue underline on the active tab. This change aligns the dark/light theme and adds the blue underline also to the light theme. Fixes: eclipse-platform#1651
BeckerWdf
force-pushed
the
active_tab_indicator
branch
from
476f8c8
to
13a18b7
Compare
|
Failing test is not related to this change. Already reported in #1005 |
|
Performed some basic manual tests for this change on Windows. The active tab is highlighted with a blue underline in both the view and editor areas, based on selection.
|
|
Sorry for the late reply. Since test on Windows was already done, I can at least contribute by confirming that it also works on GTK:
Great improvement. Thanks, Matthias! |
Add new and noteworthy entry for: eclipse-platform/eclipse.platform.ui#1652
Add new and noteworthy entry for: eclipse-platform/eclipse.platform.ui#1652
The dark theme already has such an indicator. It adds a blue underline on the active tab.
This change aligns the dark/light theme and adds the blue underline also to the light theme.
Fixes: #1651