Initialize onboarding information for all stacks in shared area #1773 #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 921 files 921 suites 45m 59s ⏱️ Results for commit ab0fc98. ♻️ This comment has been updated with latest results. |
|
@marcushoepfner since you have contributed the onboarding functionality, may I ask you to have a look at this fix? |
|
LGTM. Thanks @HeikoKlare Thanks |
|
Thanks for your feedback and the hint to the issue! |
marcushoepfner
approved these changes
Mar 26, 2024
|
Thanks @marcushoepfner! I'd like to postpose the merge of this PR after #1775 since that one becomes hard to reproduce manually once this PR has been merged. |
…se-platform#1773 The onboarding information is currently initialized for the primary editor stack in the shared area. When the shared area is split into multiple part stack showing editors side-by-side and closing the last editor in the original part stack, the onboarding information controls get lost together with that part stack. With this change, onboarding information is embedded into every part stack of the onboarding area, such that when closing one of them, the information does not get lost. To this end, every part stack is in the shared area is tagged as an editor stack and the onboarding information is added to every tab folder of part stacks tagged as an editor stack. Fixes eclipse-platform#1773
HeikoKlare
force-pushed
the
issue-1773-onboarding
branch
from
74608fa
to
ab0fc98
Compare
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this pull request
Apr 10, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtils, which currently contain functionality related to the primary data stack, which also relies on the being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this pull request
Apr 10, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil, which currently contain functionality related to the primary data stack, which also relies on the being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this pull request
Apr 10, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
This was referenced Apr 10, 2024
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this pull request
Apr 16, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
HeikoKlare
added a commit
to HeikoKlare/eclipse.platform.ui
that referenced
this pull request
Apr 18, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
HeikoKlare
added a commit
that referenced
this pull request
Apr 18, 2024
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (#1775, #1778). Contributes to #1570 Contributes to #1773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onboarding information is currently initialized for the primary editor stack in the shared area. When the shared area is split into multiple part stack showing editors side-by-side and closing the last editor in the original part stack, the onboarding information controls get lost together with that part stack.
With this change, onboarding information is embedded into every part stack of the onboarding area, such that when closing one of them, the information does not get lost. To this end, every part stack is in the shared area is tagged as an editor stack and the onboarding information is added to every tab folder of part stacks tagged as an editor stack.
Fixes #1773
Discussion of alternatives
The change relies on tagging multiple part stacks as "EditorStack". An alternative solution would be to not check for the "EditorStack" tag but to check for a part stack being placed in the shared area. Necessary adaptations to productive code would be of similar complexity, but test adaptation effort would increase as the tests currently encode the contract of identifying part stacks requiring onboarding information by the "EditorStack" tag rather than being placed in the shared area.
How to test / reproduce
You can experience the change with the following scenario (also documented in #1774):
With this change, the onboarding information is still present.