Centralize functionality for creating and identifying editor stacks #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 920 files - 1 920 suites - 1 39m 18s ⏱️ - 34m 48s For more details on these failures, see this check. Results for commit 8876f89. ± Comparison against base commit 362c51d. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
issue-1570-cleanup
branch
from
fd45929
to
9aa78d8
Compare
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack. In addition, this change reverts the preliminary fix for visible names of open editors being to short (eclipse-platform#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (eclipse-platform#1775, eclipse-platform#1778). Contributes to eclipse-platform#1570 Contributes to eclipse-platform#1773
HeikoKlare
force-pushed
the
issue-1570-cleanup
branch
from
9aa78d8
to
8876f89
Compare
|
Failing test is unrelated: #1005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality for creating and identifying editor stacks based on the "EditorStack" tag is scattered across several code places. This change centralizes the according functionality in the recently introduced
PartStackUtil. This utility class currently contains functionality related to the primary data stack, which also relies on being an editor stack.In addition, this change reverts the preliminary fix for visible names of open editors being to short (#1712) as this became obsolete with the recent improvements of handling primary data stacks and editor stacks (#1775, #1778).
Contributes to #1570
Contributes to #1773