Simplify ResourceTest#ensureOutOfSync() and #readStringInFileSystem() #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
simplify-ensureoutofsync
branch
from
1bec50d
to
bd4140c
Compare
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
simplify-ensureoutofsync
branch
from
bd4140c
to
8301a26
Compare
The utility methods ensureOutOfSync() and readStringInFileSystem(IFile) in ResourceTests use a cascade of further utility methods with partly duplicated functionality. Those methods have protected visibility but do not have any consumers outside of ensureOutOfSync(). This change simplifies these methods and streamlines the contained assertions.
HeikoKlare
force-pushed
the
simplify-ensureoutofsync
branch
from
8301a26
to
d5ceb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility methods
ensureOutOfSync()andand readStringInFileSystem(IFile)inResourceTestsuse a cascade of further utility methods with partly duplicated functionality. Those methods have protected visibility but do not have any consumers outside ofensureOutOfSync().This change simplifies these methods and streamlines the contained assertions.
This is part of preparatory work for migrating the
ResourceTeststo JUnit 4.