Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate JUnit 3 Tests to JUnit 4/5 #29

Open
HeikoKlare opened this issue Nov 16, 2023 · 1 comment
Open

Migrate JUnit 3 Tests to JUnit 4/5 #29

HeikoKlare opened this issue Nov 16, 2023 · 1 comment
Assignees
@HeikoKlare
Labels
Enhancement A Request for an Enhancement of an Existing Feature Epic An Epic Issue Platform UI Issue for Platform UI Platform Issue for Core Platform

Comments

@HeikoKlare
Copy link
Contributor

Current Situation

Many tests in the Eclipse Platform and Platform UI projects still rely on JUnit 3. While some of them are easy to migrate, in particular the ResourceTest implementation are problematic because they heavily rely on inheritance of utilities and common setup/teardown functionality. In addition, the WorkspaceSessionTests as specific ResourceTests have a custom implementation for their execution that depends on JUnit 3 API.

While JUnit 3 is quite outdated and should thus be replaced, the real issue with those tests is the inheritance hierarchy. All tests use a bunch of setup functionality and quite generic teardown functionality in the sense of a "catch all" manner rather than precisely specifying what each test class needs to set up and tear down. This can easily be realized by rules in JUnit 4 or extensions in JUnit 5.

Expected Situation

All tests in Platform and Platform UI shall be migrated to JUnit 4 or JUnit 5. Finally, the CoreTest class in the test harnes may be deprecated.
@HeikoKlare HeikoKlare converted this from a draft issue Nov 16, 2023
@HeikoKlare HeikoKlare self-assigned this Nov 16, 2023
@HeikoKlare HeikoKlare added Platform Issue for Core Platform Platform UI Issue for Platform UI Enhancement A Request for an Enhancement of an Existing Feature labels Nov 16, 2023
@HeikoKlare
Copy link
Contributor Author

PRs

Platform

Platform UI

Releng Aggregator

@HeikoKlare HeikoKlare moved this from 🔁 Ongoing to 🏗 Long running in Eclipse Nov 22, 2023
@HeikoKlare HeikoKlare added the Epic An Epic Issue label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeikoKlare HeikoKlare

Labels
Enhancement A Request for an Enhancement of an Existing Feature Epic An Epic Issue Platform UI Issue for Platform UI Platform Issue for Core Platform
Projects
Eclipse
Status: 🏗 In Work: Long
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeikoKlare