Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome page #302

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

vladarama
Copy link

What it does

Fixes: #280

This PR updates Theia Blueprint's welcome page to use the latest changes from Theia 1.41 leading to a reduction in lines of code. It also fixes two small typos that were present in the welcome page.

This update allows Blueprint to benefit from these changes:
eclipse-theia/theia#12813
eclipse-theia/theia#12750

How to test

  1. Open Theia application.
  2. Welcome page should use the latest changes from 1.41.

Review checklist

Reminder for reviewers

This commit updates Theia Blueprint's welcome page to use the latest
changes from Theia 1.41 leading to a significant reduction in lines of
code.

Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
@jfaltermeier jfaltermeier self-requested a review September 29, 2023 07:17
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me and works as expected

@jfaltermeier jfaltermeier merged commit 79e6c3c into eclipse-theia:master Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Dismissing Welcome Page
2 participants