Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: inputs variable of type pickString not evaluated #11585

Closed
MNASTM opened this issue Aug 18, 2022 · 1 comment · Fixed by #12100
Closed

tasks: inputs variable of type pickString not evaluated #11585

MNASTM opened this issue Aug 18, 2022 · 1 comment · Fixed by #12100
Labels
tasks issues related to the task system variable-resolver issues related to the variable-resolver extension

Comments

@MNASTM
Copy link

MNASTM commented Aug 18, 2022

Steps to Reproduce:

  1. Open a workspace
  2. Create tasks.json :
{
    "version": "2.0.0",
    "tasks": [
        {
            "type": "shell",
            "label": "echo pickString",
           "command": "echo",
            "args": ["${input:pickStringTest}"]
        },
        {
            "type": "shell",
            "label": "echo promptString",
            "command": "echo",
            "args": ["${input:promptStringTest}"]
        }
    ],
    "inputs": [
        {
            "type": "pickString",
            "id": "pickStringTest",
            "description": "pick string",
            "options": [
                "option1",
                "option2"
            ],
            "default": "option1"
        },
        {
            "id": "promptStringTest",
            "type": "promptString",
            "description": "prompt string",
            "default": "promptOption"
        }
    ]
}
  1. Run Task 'echo pickString'
  2. Select 'option1'
  3. See terminal output: ${input:pickStringTest}
    Expected: option1

Additional Information

  • Operating System: Windows
  • Theia Version: 1.27
@vince-fugnitto vince-fugnitto added tasks issues related to the task system variable-resolver issues related to the variable-resolver extension labels Aug 18, 2022
@sdirix
Copy link
Member

sdirix commented Jan 23, 2023

I recently stumbled about this problem in Linux too, so this issue is not restricted to Windows and is still there in the latest Theia.

sdirix added a commit to eclipsesource/theia that referenced this issue Jan 23, 2023
Similar to 'promptString', 'pickString' can be used to replace variables in task and
launch configurations. However 'pickString' values were not correctly handled which
prevented them from being evaluated. This is now fixed.

Fixes eclipse-theia#11585

Contributed on behalf of STMicroelectronics
sdirix added a commit to eclipsesource/theia that referenced this issue Jan 23, 2023
Similar to 'promptString', 'pickString' can be used to replace variables in task and
launch configurations. However 'pickString' values were not correctly handled which
prevented them from being evaluated. This is now fixed.

Fixes eclipse-theia#11585

Contributed on behalf of STMicroelectronics
JonasHelming pushed a commit that referenced this issue Jan 24, 2023
Similar to 'promptString', 'pickString' can be used to replace variables in task and
launch configurations. However 'pickString' values were not correctly handled which
prevented them from being evaluated. This is now fixed.

Fixes #11585

Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system variable-resolver issues related to the variable-resolver extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants