Skip to content

Commit

Permalink
Fix 'pickString' evaluation
Browse files Browse the repository at this point in the history
Similar to 'promptString', 'pickString' can be used to replace variables in task and
launch configurations. However 'pickString' values were not correctly handled which
prevented them from being evaluated. This is now fixed.

Fixes eclipse-theia#11585

Contributed on behalf of STMicroelectronics
  • Loading branch information
sdirix committed Jan 23, 2023
1 parent ca59f1d commit 4f2b779
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ export class CommonVariableContribution implements VariableContribution {
});
}
}
return this.quickInputService?.showQuickPick(elements, { placeholder: input.description });
const selectedPick = await this.quickInputService?.showQuickPick(elements, { placeholder: input.description });
return selectedPick?.value;
}
if (input.type === 'command') {
if (typeof input.command !== 'string') {
Expand Down

0 comments on commit 4f2b779

Please sign in to comment.