Git extension does not detect changes

[tsmaeder]

Bug Description:

The git "Changes" view remains empty when I change a file in an editor.

Steps to Reproduce:

1. Open Theia IDE on the Theia source code
2. Open a file in the editor, e.g. 'npmignore' and add a line at the end
3. Save the file
4. Observe: the git "changes" view remains empty. When I hit "refresh" in the "GIT" view toolbar, the change appears.

Additional Information

• Operating System: Window 11
• Theia Version: 1.55.0 Theia IDE

[tsmaeder]

I've also seen some failed updates in the file explorer as well. So my first instinct would be to blame the replaced file watcher infrastructure.

[tsmaeder]

Unfortunately, I can't reproduce this in the electron example built from source.

[tsmaeder]

I restarted my machine and the file watching works again in Theia IDE 1.55.0. There seems to be some system-level code getting stuck somehow.

[safisa]

@tsmaeder I had similar issues with Theia Web 1.55, both in the file explorer and in the Git (source control) tree. In some cases, I had to click the tree's refresh icon to see the new/deleted file changes. Reloading the page fixes the issue.

Unfortunately, I don't have specific steps to reproduce this issue.

[tsmaeder]

A little update:

First I thought we were running into a case where ReadDirectoryChangesW was running into ERROR_NOTIFY_ENUM_DIR indicating there are too many changes. But I was not seeing that in the log.

I noticed parcel-bundler/watcher#187 and update to the 2.5.0 version of @parcel/watcher. Now I'm getting the following error:

2024-11-27T15:33:34.326Z root ERROR [parcel-watcher: 23356] Watcher service error on "C:\Users\thomas\code\theia\theia5\node_modules\@discoveryjs\json-ext": [Error: Failed to read changes]

in the log, but if we were getting ERROR_NOTIFY_ENUM_DIR, the error message should be ""Buffer overflow. Some events may have been lost.". So I suspect before we were running into the deadlock from the mentioned issue and now we run into a different error. Needs more digging.

[tsmaeder]

I had an editor open on the file mentioned in the above error log and I seem to recall that the watcher throws an error when deleting a file that is being watched. That makes sense. Otherwise I'm optimistic that simple version update fixes the symptoms described in this issue.
The fact that we're not handling the case of ERROR_NOTIFY_ENUM_DIR is still a problem, but might not be causing the current issue. This needs more testing, though.