Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parcel watcher to 2.5.0 #14545

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

tsmaeder
Copy link
Contributor

What it does

This should fix #14529

Contributed on behalf of STMicroelectronics

There was a deadlock issue in @parcel/watcher 2.4.x that is consistent with the behavior we were observing (see issue). I could reliably reproduce the issue with the scenario described in "How to test". After the update, I can't reproduce the issue with that scenario.

How to test

  1. Open two Electron Theia Windows on two different copies of the Theia source code.
  2. Repeatedly and concurrently run yarn and git clean -xfd on the command line in the two source root folders.
  3. Observe: without the update, eventually not file changes would be detected anymore. With the update, the file changes continue to work (change a file and observe that the file shows up in the git "changes" view.

Follow-ups

Review checklist

Reminder for reviewers

This should fix eclipse-theia#14529

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested a review from msujew November 27, 2024 16:09
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works for me. Without the PR I never get any change automatically into the source view. With the PR it works without issues.

@tsmaeder tsmaeder merged commit ab92800 into eclipse-theia:master Nov 28, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.56.0 milestone Nov 28, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, just wanted to tell that the fix works well for me as well.

tsmaeder added a commit that referenced this pull request Dec 2, 2024
This should fix #14529

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Git extension does not detect changes
3 participants