Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Bar Problems in Theia IDE #14586

Closed
tsmaeder opened this issue Dec 4, 2024 · 7 comments · Fixed by #14587 or #14592
Closed

Scroll Bar Problems in Theia IDE #14586

tsmaeder opened this issue Dec 4, 2024 · 7 comments · Fixed by #14587 or #14592
Milestone

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 4, 2024

Bug Description:

In Theia IDE, tree views like the Explorer cannot be scrolled: there is an overlay covering 100% coming in when hovering over the the vertical scroll bar.

Steps to Reproduce:

  1. Open the navigator on a Theia repo, expand node_modules
  2. Observe: you get a scroll bar with a thumb of some length
  3. Try to grab the scroll-thumb and move it
  4. Observe: you can't.

Additional Information

  • Operating System: Windows 11
  • Theia Version: 1.56.1 Theia IDE

Since we can't fix this for adopters who build their own Theia-based products, I've sent the following message to the dev mailing list for a work around:

we've noticed a problem when creating the new IDE release 1.56.1: #14586. We are, of course, preparing a new release. The problem was caused by picking up a new point version of the "perfect-scrollbar" dependency. The 1.5.6 version is not working with Theia and we're pinning the version to 1.5.5 in Theia IDE. Unfortunately, we cannot force clients of the @Theia packages to use the 1.5.5 version due to limitations in yarn.

So if you build your own Theia-based product you should pin the version as well by adding the following to the package.json at the root of your monorepo:

"resolutions": {
"**/perfect-scrollbar": "1.5.5"
},

You can also check which version of perfect-scrollbar you're using in your product by doing "yarn why perfect-scrollbar". If the versions showing up are < 1.5.6, you're fine.

Being unable to update this dependency is not desirable in the long run and we'll investigate what the root cause of the problem is and take appropriate action.

hope that helps

/Thomas

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 4, 2024

scroll_issue

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 4, 2024

Note: you can't reproduce this in Theia master. Turns out Theia IDE picked up an update of perfect-scrollbar from 1.5.5 to 1.5.6. We need to pin perfect-scrollbar at 1.5.5 for the time being.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Dec 4, 2024
Fixes  eclipse-theia#14586

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder added a commit that referenced this issue Dec 5, 2024
Fixes  #14586

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder reopened this Dec 5, 2024
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 5, 2024

Turns out the pinning does not work like this for adopters.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Dec 5, 2024
Fixes eclipse-theia#14586

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 5, 2024

Since we can't fix this for adopters who build their own Theia-based products, I've sent the following message to the dev mailing list:

we've noticed a problem when creating the new IDE release 1.56.1: #14586. We are, of course, preparing a new release. The problem was caused by picking up a new point version of the "perfect-scrollbar" dependency. The 1.5.6 version is not working with Theia and we're pinning the version to 1.5.5 in Theia IDE. Unfortunately, we cannot force clients of the @Theia packages to use the 1.5.5 version due to limitations in yarn.

So if you build your own Theia-based product you should pin the version as well by adding the following to the package.json at the root of your monorepo:

"resolutions": {
"**/perfect-scrollbar": "1.5.5"
},

You can also check which version of perfect-scrollbar you're using in your product by doing "yarn why perfect-scrollbar". If the versions showing up are < 1.5.6, you're fine.

Being unable to update this dependency is not desirable in the long run and we'll investigate what the root cause of the problem is and take appropriate action.

hope that helps

/Thomas

@sdirix
Copy link
Member

sdirix commented Dec 5, 2024

What we could do is to add a patch to theia-patch which reverts the changes of perfect-scrollbar 1.5.6. patch-package is aware of versions and will only apply the patch on the broken version.

However I think that many adopters are not even using theia-patch, so that will not help them.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Dec 5, 2024

What we could do is to add a patch to theia-patch which reverts the changes of perfect-scrollbar 1.5.6.

I don't think that's a sustainable solution. When 1.5.7 comes out we'll have to update the patch and that ad infinitum?

@sdirix
Copy link
Member

sdirix commented Dec 5, 2024

I agree, it's absolutely not a long term solution. The only "real" solutions are:

  • Report/Fix/Release a fix upstream, i.e. in perfect-scrollbar
  • Workaround/Fix the issue within Theia
  • Get rid of perfect-scrollbar

The suggestion of theia-patch would just be a convenience workaround for adopters until the issue is actually resolved. I'm definitely fine with not doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants