Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin perfect-scrollbar to 1.5.5 #14587

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Dec 4, 2024

What it does

This PR tries to prevent updating to version 1.5.6 of perfect-scrollbar for adopters. Scrolling views like the explorer is broken with this version

Fixes #14586

Contributed on behalf of STMicroelectronics

How to test

Make sure you can scroll reliably in views like the breakpoints view or the file explorer.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

Fixes  eclipse-theia#14586

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested review from msujew and sgraband December 4, 2024 17:08
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsmaeder tsmaeder merged commit 8378858 into eclipse-theia:master Dec 5, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 5, 2024
tsmaeder added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Scroll Bar Problems in Theia IDE
2 participants