Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift + Space should output a space (blank) character in the editor unless other key bindings are used #14665

Closed
ReasonSharp opened this issue Dec 20, 2024 · 5 comments · Fixed by #14669

Comments

@ReasonSharp
Copy link

Bug Description:

I'll often write SQL in the editor and capitalize keywords by holding down the SHIFT key. This means I will hold the SHIFT key while typing the space character as well (and sometimes will still hold the SHIFT key when I press the spacebar after I type other characters in code, such as {}!<>, etc. due to typing speed), as I do in multiple other IDEs and editors.

However, recently Theia stopped recognizing Shift + Space as me intending to type a space character, causing syntax errors and/or poorly formatted code.

I've checked for key bindings and indeed there was the Shift + Space and Ctrl + Shift + Space key binding to some actions I've never used, so I removed those. However, this hasn't resolved the issue - Shift + Space still doesn't type the space character as expected, even after restarting Theia.

Steps to Reproduce:

  1. Focus the editor
  2. Press Shift + Space (the blank whitespace character will not be typed)
  3. Remove all key bindings related to Shift + Space and restart Theia
  4. Press Shift + Space while focused on editor (still, the blank isn't typed)

Expected Behavior:

When pressing Shift + Space in code editor, Theia should place a blank whitespace character (0x20) at cursor position, as is the case with virtually all other editors, consoles, etc.

Additional Information

  • Operating System: Debian
  • Theia Version: 1.57.0
@JonasHelming JonasHelming transferred this issue from eclipse-theia/theia-ide Dec 23, 2024
@JonasHelming
Copy link
Contributor

Thank you for the report. This is almost certainly a regression of #14393
But what I don't get is why it does not work if you unbind the new command (inline completion). I will try to reprduce this and we should probably bind the inline completion to something else then.

@JonasHelming
Copy link
Contributor

First identified issue is the the override of default commands does not work as expected, see #14667 (I already pushed a fix)

@JonasHelming
Copy link
Contributor

Second, this #14669 changes the default of the trigger inline suggestion to Ctrl+Alt+Space to avoid the issue you reported in the first place.

@tsmaeder
Copy link
Contributor

What's the trigger for "inline suggestion" in VS Code? No need to be different.

@JonasHelming
Copy link
Contributor

None! The default of Github Copilot is to trigger automatically on the fly, which can be pretty annoying. Our default is via a key binding (you can turn automatic on)

JonasHelming added a commit that referenced this issue Dec 25, 2024
* Change trigger inline suggestion keybinding to Ctrl+Alt+Space

fixed #14665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants