Add manual AI code completion #14393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add preference to turn on/off automatic trigger while editing - Add shortcut for explicit, manual trigger through command
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
JonasHelming
force-pushed
the
issues/ai-manual-completion
branch
from
a790c00 to
06f2bed
Compare
JonasHelming
changed the title
sdirix
approved these changes
Nov 7, 2024
packages/ai-code-completion/src/browser/ai-code-completion-preference.ts
Outdated
Show resolved
Hide resolved
…ference.ts Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixed #14392
How to test
Go to settings => code completion and toggle "Automatic Code Completion"
If "Automatic" => code completion immediatly appears
If Not "automatic" => code completion only appears on SHIFT+SPACE
If AI is generally disabled or the code completion agent is disabled, none of the two options trigger
Follow-ups
It might be nice to show some sort of progress for the non-automatic option, especially for slower LLMS.
Review checklist
Reminder for reviewers