Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget was activated, but did not accept focus is flaky #1707

Closed
akosyakov opened this issue Apr 15, 2018 · 2 comments
Closed

Widget was activated, but did not accept focus is flaky #1707

akosyakov opened this issue Apr 15, 2018 · 2 comments
Assignees
@akosyakov
Labels
shell issues related to the core shell

Comments

@akosyakov
Copy link
Member

Got false positives during debugging and on slow connections. To reproduce open an editor, throttle your connection (not with Chrome - it cannot throttle web sockets), refresh the page.
@spoenemann
Copy link
Contributor

See #1061 and #1604.

@spoenemann
Copy link
Contributor

The current implementation waits for one animation frame and then checks focus. We should change it to wait further animation frames if focus is still not set, up to some maximum like 10 frames or so.

@akosyakov akosyakov self-assigned this Jul 31, 2019
@akosyakov akosyakov added the shell issues related to the core shell label Jul 31, 2019
akosyakov added a commit that referenced this issue Jul 31, 2019
@akosyakov
fix #1707: check widget activation based on events, not timing
9c4cc4e 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jul 31, 2019
Merged
44 tasks
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation based on events, not timing
f8460e7 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation only for last widget, after 2s
d8aac91 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation only for last widget, after 2s
ca9df31 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation only for last widget, after 2s
adc7d2d 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation only for last widget, after 2s
94c8539 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 2, 2019
@akosyakov
fix #1707: check widget activation only for last widget, after 2s
80c4e86 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
shell issues related to the core shell
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @spoenemann