Log a warning when a widget is explicitly activated, but it does not accept focus #1604
Conversation
spoenemann
force-pushed
the
msp_issue1061
branch
from
e910817 to
cdcb308
Compare
| private checkActivation(widget: Widget): Widget { | ||
| window.requestAnimationFrame(() => { | ||
| if (this.activeWidget !== widget) { | ||
| this.logger.warn("Widget was activated, but did not accept focus: " + widget.id); |
There was a problem hiding this comment.
I have tried it out (removed the if statement to always log); it worked. Unfortunately, this logging does not show up in the browser console but only in the backend console. I do not know whether it was on purpose, but if you would use console.warn instead of logger.warn, it would log to both places. What do you think?
[2018-03-30T07:40:52.944Z] WARN: Theia/11837 on prprpr.fritz.box: Widget was activated, but did not accept focus: code-editor-opener:file:///Users/akos.kitta/Desktop/theia/.npmignore []
There was a problem hiding this comment.
Does Electron support the browser console?
There was a problem hiding this comment.
I would say; yes. (I have not tried it though.)
There was a problem hiding this comment.
Do we have any guideline on when to use console and when to use ILogger?
There was a problem hiding this comment.
I changed this to console.warn.
There was a problem hiding this comment.
console.warn is good, if you use ILogger it will end up only on the backend, via console you can log in the browser console and to the backend at the same time.
…es not accept focus Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
spoenemann
force-pushed
the
msp_issue1061
branch
from
cdcb308 to
06c0028
Compare
This does not really fix #1061, but it helps to find problems in that context.