Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUri gets loaded in browser #4272

Closed
akosyakov opened this issue Feb 7, 2019 · 3 comments
Closed

FileUri gets loaded in browser #4272

akosyakov opened this issue Feb 7, 2019 · 3 comments
Labels
bug bugs found in the application plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

git and plugin extensions causing it.

It is bogus to use FileUri.fsPath on the frontend, one should retrieve fsPath from the backend with FileSystem.getFsPath.
@akosyakov akosyakov added bug bugs found in the application git issues related to git plug-in system issues related to the plug-in system help wanted issues meant to be picked up, require help labels Feb 7, 2019
kittaakos pushed a commit that referenced this issue Feb 11, 2019
GH-4272: Got rid of the FileUri dependency from the Git frontend code.
a15e82a 
Used the FS instead.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this issue Feb 11, 2019
Merged
@kittaakos
Copy link
Contributor

git

#4302

kittaakos pushed a commit that referenced this issue Feb 12, 2019
@kittaakos
GH-4272: Got rid of the FileUri dependency from the Git frontend code.
1955032 
Used the FS instead.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos removed the git issues related to git label Feb 12, 2019
@kittaakos
Copy link
Contributor

The Git part was fixed via 1955032.

@evidolob evidolob mentioned this issue Apr 19, 2019
Closed
50 tasks
@ashumilova ashumilova mentioned this issue Apr 23, 2019
Closed
25 tasks
@evidolob evidolob mentioned this issue May 6, 2019
Closed
26 tasks
@evidolob evidolob mentioned this issue May 15, 2019
Closed
30 tasks
@mmorhun
Copy link
Contributor

mmorhun commented May 31, 2019

plugin-ext fixed in #5314

@mmorhun mmorhun closed this as completed May 31, 2019
@mmorhun mmorhun removed the help wanted issues meant to be picked up, require help label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittaakos @akosyakov @mmorhun