Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-4272: Got rid of the FileUri dependency from the Git frontend code. #4302

Merged
merged 1 commit into from
Feb 12, 2019
Merged

GH-4272: Got rid of the FileUri dependency from the Git frontend code. #4302

merged 1 commit into from
Feb 12, 2019

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 11, 2019 •
edited
Loading

Used the FS instead.

Issue: #4272.

Signed-off-by: Akos Kitta kittaakos@typefox.io

GH-4272: Got rid of the FileUri dependency from the Git frontend code.
a15e82a 
Used the FS instead.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@kittaakos kittaakos mentioned this pull request Feb 11, 2019
Closed
AlexTugarev
AlexTugarev approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlexTugarev
Copy link
Contributor

There is another import { FileUri } from '@theia/core/lib/node/file-uri'; in packages/plugin-ext/src/hosted/browser/hosted-plugin-manager-client.ts.

@kittaakos kittaakos merged commit 1955032 into master Feb 12, 2019
@kittaakos kittaakos deleted the GH-4272-git branch February 12, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @AlexTugarev