Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate TypeScript only if needed #6163

Closed
AlexTugarev opened this issue Sep 11, 2019 · 1 comment · Fixed by #6164
Closed

Activate TypeScript only if needed #6163

AlexTugarev opened this issue Sep 11, 2019 · 1 comment · Fixed by #6164
Assignees
@AlexTugarev
Labels
bug bugs found in the application typescript issues related to the typescript language

Comments

@AlexTugarev
Copy link
Contributor

An initial typescript.server.log preference change events currently activates the TypeScript language contribution even if there is no TypeScript project in the workspace.
@AlexTugarev AlexTugarev added bug bugs found in the application typescript issues related to the typescript language labels Sep 11, 2019
@AlexTugarev AlexTugarev self-assigned this Sep 11, 2019
AlexTugarev added a commit that referenced this issue Sep 11, 2019
@AlexTugarev
[typescript] avoid activation on startup if there is no other activat…
e2ffed4 
…ion event

Fixes #6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@AlexTugarev AlexTugarev mentioned this issue Sep 11, 2019
Merged
2 tasks
AlexTugarev added a commit that referenced this issue Sep 11, 2019
@AlexTugarev
[typescript] avoid activation on startup if there is no other activat…
4916bd2 
…ion event

Fixes #6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Sep 11, 2019
@AlexTugarev
[typescript] avoid activation on startup if there is no other activat…
b725c1b 
…ion event

Fixes #6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
AlexTugarev added a commit that referenced this issue Sep 12, 2019
@AlexTugarev
[typescript] avoid activation on startup if there is no other activat…
41a5d5c 
…ion event

Fixes #6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
@akosyakov
Copy link
Member

resolved by #6164

akosyakov pushed a commit that referenced this issue Sep 13, 2019
@AlexTugarev @akosyakov
[typescript] avoid activation on startup if there is no other activat…
00229b9 
…ion event

Fixes #6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@AlexTugarev @akosyakov
[typescript] avoid activation on startup if there is no other activat…
2acbb04 
…ion event

Fixes eclipse-theia#6163

Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexTugarev AlexTugarev

Labels
bug bugs found in the application typescript issues related to the typescript language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[typescript] avoid activation on startup if there is no other activation event eclipse-theia/theia
2 participants
@AlexTugarev @akosyakov