-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] avoid activation on startup if there is no other activation event #6164
Conversation
Should not we generally fix |
packages/typescript/src/browser/typescript-client-contribution.ts
Outdated
Show resolved
Hide resolved
really good question. is there a chance that activation might fail, but a second try would be successful? in that case, calling restart manually would stop working at all, no? |
restart is not available if the server is not running: https://github.com/theia-ide/theia/blob/732ef15589b668c456590276bebba9fcfa37f409/packages/languages/src/browser/languages-frontend-contribution.ts#L75-L82 I think it is safe to add a guard in |
4916bd2
to
b725c1b
Compare
@akosyakov I changed again and added the guard in |
@AlexTugarev check boxes are for reviewers or for you? :) |
for reviewers ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested that ts support is there if a project contains tsconfig and is not there if not
@AlexTugarev please rebase and if the ci is green please merge |
…ion event Fixes #6163 Signed-off-by: Alex Tugarev <alex.tugarev@typefox.io>
b725c1b
to
41a5d5c
Compare
Fixes #6163
How to test
Signed-off-by: Alex Tugarev alex.tugarev@typefox.io