Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dependencies] 'editor-preview' needlessly pulls 'navigator' #6639

Closed
vince-fugnitto opened this issue Nov 26, 2019 · 0 comments · Fixed by #6648
Closed

[dependencies] 'editor-preview' needlessly pulls 'navigator' #6639

vince-fugnitto opened this issue Nov 26, 2019 · 0 comments · Fixed by #6648
Labels
dependencies pull requests that update a dependency file editor-preview issues that are related to the editor-preview

Comments

@vince-fugnitto
Copy link
Member

Description

The @theia/editor-preview extension needlessly pulls the @theia/navigator extension.
The dependency is declared but is unused throughout the extension. It is likely a leftover from 00e7d9d.

"@theia/navigator": "^0.12.0"

image

@vince-fugnitto vince-fugnitto added editor-preview issues that are related to the editor-preview dependencies pull requests that update a dependency file labels Nov 26, 2019
vince-fugnitto added a commit that referenced this issue Nov 27, 2019
Fixes #6639

- removes the unused `navigator` from the `editor-preview` extension.
- the `navigator` was needlessly pulled by the `editor-preview` as it was
never used and is likely to be a leftover of 00e7d9d.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 28, 2019
Fixes #6639

- removes the unused `navigator` from the `editor-preview` extension.
- the `navigator` was needlessly pulled by the `editor-preview` as it was
never used and is likely to be a leftover of 00e7d9d.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
Fixes eclipse-theia#6639

- removes the unused `navigator` from the `editor-preview` extension.
- the `navigator` was needlessly pulled by the `editor-preview` as it was
never used and is likely to be a leftover of 00e7d9d.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file editor-preview issues that are related to the editor-preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant