[editor-preview] remove unnecessary 'navigator' dependency

[vince-fugnitto]

What it does

Fixes #6639

• removes the unused navigator from the editor-preview extension.
• the navigator was needlessly pulled by the editor-preview as it was never used and is likely to be a leftover of 00e7d9d.

How to test

• verify that CI passes (editor-preview builds and the tests pass)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[marcdumais-work]

LGTM. A few notes:

• I think the suggested test will not be conclusive, since the navigator is pulled (at least indirectly) from multiple Theia extensions used in the example application
• I have manually checked that, indeed, the dependency looks unused ATM
• removing the dependency will not practically change anything, but it will not hurt either, and its technically correct :)

[vince-fugnitto]

LGTM. A few notes:

• I think the suggested test will not be conclusive, since the navigator is pulled (at least indirectly) from multiple Theia extensions used in the example application

Yes you are right, a more exhaustive test would be to create an application that pulls the editor-preview without a navigator (which might be difficult at the moment due to coupling in other areas). I mentioned the test because I wanted to make sure that unit tests execute successfully.

• I have manually checked that, indeed, the dependency looks unused ATM

👍

• removing the dependency will not practically change anything, but it will not hurt either, and its technically correct :)

I think so too, I don't think we should have dependencies without the actual need for them, it makes the package.json of those such extensions confusing.